Ticket #140 (closed task: fixed)
callouts/video/events/news folders have no name in left nav when a new member signs up
| Reported by: | and | Owned by: | datakid |
|---|---|---|---|
| Priority: | major | Milestone: | 0.2 |
| Component: | ATEngageVideo | Severity: | |
| Keywords: | Cc: | ||
| Who will test this: |
Description
These two members signed up post shift to 3 columns
http://www.engagemedia.org/Members/preranar http://www.engagemedia.org/Members/klnkng/news/
Older members appear to be fine.
Attachments
Change History
comment:2 Changed 5 years ago by datakid
It also occured to me that since the callouts (the newest addition to this area) have gone to the top, that somehow they were a little bit malformed (no "title"?) and that this has flowed down to the other folders (videos, news, events).
I could be really wrong too.
comment:3 Changed 5 years ago by datakid
And it would seem that I am. See the following comparison between the Tasmedia user (pre update user, folders render well) and the preranar user (post update user, folders don't render).
<li class="navTreeItem visualNoMarker">
<div class="visualIcon contenttype-folder">
<a href="http://www.engagemedia.org/Members/Tasmedia"
class="state-published visualIconPadding"
title="">Tasmedia</a>
</div>
<ul class="navTree navTreeLevel3">
<li class="navTreeItem visualNoMarker">
<div class="visualIcon contenttype-atengagevideofolder">
<a href="http://www.engagemedia.org/Members/Tasmedia/videos"
class="state-published visualIconPadding"
title="">Videos</a>
</div>
<li class="navTreeItem visualNoMarker">
<div class="visualIcon contenttype-folder">
<a href="http://www.engagemedia.org/Members/preranar"
class="state-published visualIconPadding navTreeCurrentItem"
title="">preranar</a>
</div>
<ul class="navTree navTreeLevel3">
<li class="navTreeItem visualNoMarker">
<div class="visualIcon contenttype-callout-folder">
<a href="http://www.engagemedia.org/Members/preranar/callouts"
class="state-published visualIconPadding"
title=""></a>
</div>
</li>
The problem presents itself - the links aren't being populated with text:
Tasmedia:
<div class="visualIcon contenttype-atengagevideofolder">
<a href=" http://www.engagemedia.org/Members/Tasmedia/videos"
class="state-published visualIconPadding"
title="">Videos</a>
</div>
vs preranar:
<div class="visualIcon contenttype-callout-folder">
<a href=" http://www.engagemedia.org/Members/preranar/callouts"
class="state-published visualIconPadding"
title=""></a>
</div>
From further looking around, it looks like it might be a problem with the default-member-content? Nothing in there has any properties.
Also, the ordering of the folders is different for different users: Tasmedia and EngageMedia have them in this order, spelling and caps in the nav-tree: Videos, News, Events, Callouts Note that in the middle column, they are in alphabetical order (instead of reverse)
While preranar has them as follows: callouts, videos, news, events (no caps cos no text in the navtree). In the middle column, they are in the following order: events, news, videos, callouts. They are folders, but they are not capitalized?
Observering, observing, eventually the truth will appear.
comment:4 Changed 5 years ago by datakid
- Owner changed from andycat to datakid
- Status changed from new to assigned
w00t!
Ok, I was right, and I've fixed it in testing.
The problem was that the default_member_content items did not have titles. You can get see what I mean when you go through the ZMI to default_member_content (login required)
And when you click through to one, eg callouts and then go ot the properties tab, the titles were empty (despite there being a "Warning: be aware that removing 'title' without re-adding it might be dangerous." note)
I added some titles to each item and created a new user ltest - you can check here - and the folders now have names.
The ordering is still different, but the first problem now has a solution. I will now endevour to find the code and fix.
ok, now, how to
comment:5 Changed 5 years ago by datakid
So I presume the code is: PlumiSkin/Extensions/Install?.py
in the
addDefaultMemberSkeleton function
In particular:
default_member_folder.invokeFactory('Callout Folder', CALLOUT_FOLDER['id'], CALLOUT_FOLDER['title'])
default_member_folder.invokeFactory('ATEngageVideoFolder', VIDEO_FOLDER['id'], VIDEO_FOLDER['title'])
default_member_folder.invokeFactory('Folder', NEWS_FOLDER['id'], NEWS_FOLDER['title'])
default_member_folder.invokeFactory('Folder', EVENTS_FOLDER['id'], EVENTS_FOLDER['title'])
While they look ok, I presume there is something missing here. When I googled default_member_folder.invokeFactory there are only two results - both are an old plumi changeset from 2006 :) in which the following:
- default_member_folder.invokeFactory('Folder', id='videos', title='Videos')
- default_member_folder.invokeFactory('Folder', id='news', title='News')
- default_member_folder.invokeFactory('Folder', id='events', title='Events')
was removed and put into ATVideo. It has since been put back into PlumiSkin? it would appear since a quick look in ATVideo shows nothing that looks like this.
I'm not sure what else I can do, since I am now over my head. Andycat? Axxs?
comment:6 Changed 5 years ago by datakid
bah, who needs coders.
I found the problem, I tested my solution here at home, and it worked. Bug fixed, ticket closed.
changeset here: http://dev.plone.org/collective/changeset/57021
The only problem I see now is that the members who joined up in that 2 or 3 month period still have no titles on their folders.
Next time I will try not to type every thought in my head as I fix things.
comment:7 Changed 5 years ago by andycat
- Status changed from assigned to closed
- Resolution set to fixed
http://dev.plone.org/collective/changeset/57104
commited to trunk this time ;)
Ive tested on a local install on my laptop - this works- closing the ticket

i had a look at this - they are missing the "title" field in the html.
Sorry, the title field is there, but it is "". This is not a CSS issue, but rather a plumi/plone issue (as was suggested to me in #plone), since the text color is #009999, not #FFFFFF.
I went looking for where the problem originates, but my plone is not good enough :)